(no title)
eoin_murphy | 10 years ago
I've yet to find a code review process beyond a trivial implementation that scaled. The best results I've had were with a rotating buddy system. (Every week/month) you review someone else's code and they yours.
eoin_murphy | 10 years ago
I've yet to find a code review process beyond a trivial implementation that scaled. The best results I've had were with a rotating buddy system. (Every week/month) you review someone else's code and they yours.
partycoder|10 years ago
- cyclomatic complexity
- statement length, function length
- number of singletons / global instances
- dead code
- duplicated code (intelliJ has a good duplicate detector that anonymizes variables and ignores whitespace and comments).
- number of known functions/types per file (coupling)
- number of commits per file (git-effort from git-extras)
Some of them are tricky to obtain. Making a simple script that parses import statements and outputs a DOT file with a digraph is useful to map dependencies, which is good to explain coupling.