top | item 12428876

(no title)

samuellb | 9 years ago

On the other hand, it's quite convenient to not have to do null checks in debug messages. Compare:

log.trace("doStuff(" + obj1 + ", " + obj2 + ")");

to this:

log.trace("doStuff(" + (obj1 != null ? obj1 : "null") + ", " + (obj2 != null ? obj2 : "null") + ")");

The second one is IMHO quite hard to read, even in this short example (and code readability is important when you do code reviews)

discuss

order

tomtomtom777|9 years ago

That is why you should use string formatting instead of concatenation.

For string formatting, rendering "null" (or "") makes sense; for coercion not.

richardwhiuk|9 years ago

That just resolves into everyone always doing formatting, and never doing concatenation, which yields the same problem.