This is kinda awesome only because lots of people can't tell if it's a joke or not. I'm reasonably confident it is, but the fact that a lot of people can't tell makes it pretty funny. And, the account that posted it is seemingly new enough to programming to maybe have no idea that it's ridiculous. So, it may even be sincere, which is less funny, but still caused me to think about it for a minute.
Also, I admire the handful of people who commented with a sincere explanation about why it's wrong. I don't have that much patience, but I'm happy that people who do exist.
It's quite funny, but I think (hope) that it's a satirical poke at JS minification...?
(... which, admittedly, would be quite strange now that I think about it. I didn't check, but I assume that there was no variable renaming in the "added line". Hmm... Regardless, I had a good laugh, so it's all good.)
I do indent my code, but I very rarely insert syntactically irrelevant spaces. I don't mind if clang-format (etc.) puts them in for me, but I don't add them by pressing keys myself and I don't have a problem reading code that leaves them out (since that code looks just like the code I write myself before I run it through clang-format).
This has long been my habit, since I started out on a computer with 32K RAM, where putting in extra spaces just meant you'd need to use shorter variable names to balance things out.
(Here's a photo of some representative code I wrote for a reddit contest a couple of years ago: http://ffe3.com/pics/.beeb/IMG_1373.JPG - not much different from what I wrote in the early 1990s as a teenager. But I did typically use longer variable names back then, because unlike this case I wasn't concerned about fitting the whole listing on one 40x25 screen...)
Even today, doing this still means fewer L1 cache misses in the scanner.
Your program had to share memory with the source code, so you didn't waste bytes on spaces! (You also used single character variable names as much as possible and jammed as many statements on a line as possible since the overhead per line was a few bytes.)
As a result I can still read very dense code, but I'm reformed and write code that uses white space to avoid an overly busy screen, suggest coupling in the underlying logic, aligns comments, etc.
I'm fairly sure that there's almost no serious kernel developer answering here. Kernel contributions don't go through github PRs but through mailing lists. The "tough crowd" you see here are trolls - not the actual community, which is inclusive and quite nice to work with.
Ah, someone must have mistaken this for the Gentoo repository. This sort of patch should be maintained by downstream distributions where concerns like speed are overriding concerns.
Me, personally? I found that compiling was a lot faster if I ran "rm -rf ." first.
It's almost certainly a joke, but defaulting to treating things you think are a bad idea as if they were jokes is fairly hostile behavior which makes it impossible for controversial issues to be discussed because someone will treat the side they don't support as being so obviously stupid it must be a joke, which can be dismissed without consideration.
v8 used the string length of a function, including comments, to determine whether to inline. HotSpot used (uses?) bytecode length of a method, so adding useless lines would affect performance.
[+] [-] SwellJoe|8 years ago|reply
Also, I admire the handful of people who commented with a sincere explanation about why it's wrong. I don't have that much patience, but I'm happy that people who do exist.
[+] [-] crispinb|8 years ago|reply
What I can clearly see is the whole reason I left working in tech: the field is stuffed full of deeply unpleasant and unkind people.
[+] [-] lomnakkus|8 years ago|reply
(... which, admittedly, would be quite strange now that I think about it. I didn't check, but I assume that there was no variable renaming in the "added line". Hmm... Regardless, I had a good laugh, so it's all good.)
[+] [-] whipoodle|8 years ago|reply
[+] [-] Retr0spectrum|8 years ago|reply
This would completely eliminate waiting for kernel compilation.
[+] [-] kbr|8 years ago|reply
[+] [-] to3m|8 years ago|reply
This has long been my habit, since I started out on a computer with 32K RAM, where putting in extra spaces just meant you'd need to use shorter variable names to balance things out.
(Here's a photo of some representative code I wrote for a reddit contest a couple of years ago: http://ffe3.com/pics/.beeb/IMG_1373.JPG - not much different from what I wrote in the early 1990s as a teenager. But I did typically use longer variable names back then, because unlike this case I wasn't concerned about fitting the whole listing on one 40x25 screen...)
Even today, doing this still means fewer L1 cache misses in the scanner.
[+] [-] copx|8 years ago|reply
Have you ever seen how the ancient Romans wrote Latin? Not only no white space, no interpunctuation either, and everything in uppercase. E.g: http://ratcliffe-college.co.uk/wp-content/uploads/2015/09/La...
So instead of..
.. you should just write: Now that is concise code![+] [-] jmull|8 years ago|reply
I got started on Commodore BASIC on an 8K PET.
Your program had to share memory with the source code, so you didn't waste bytes on spaces! (You also used single character variable names as much as possible and jammed as many statements on a line as possible since the overhead per line was a few bytes.)
As a result I can still read very dense code, but I'm reformed and write code that uses white space to avoid an overly busy screen, suggest coupling in the underlying logic, aligns comments, etc.
[+] [-] userbinator|8 years ago|reply
[+] [-] altotrees|8 years ago|reply
[+] [-] roblabla|8 years ago|reply
[+] [-] chainsaw10|8 years ago|reply
I'm pretty sure C keywords require a space on either side...
[+] [-] Jach|8 years ago|reply
[+] [-] Pxtl|8 years ago|reply
[+] [-] AaronFriel|8 years ago|reply
Me, personally? I found that compiling was a lot faster if I ran "rm -rf ." first.
[+] [-] roywiggins|8 years ago|reply
[+] [-] msla|8 years ago|reply
[+] [-] eigenbom|8 years ago|reply
[+] [-] fka|8 years ago|reply
Details (in Turkish): https://palmiyria.blogspot.com.tr/2017/05/test-yazisi.html?m...
[+] [-] fka|8 years ago|reply
post about this troll: 24.05.2017 github pr: 17.07.2017 the SS on post: 25.07.2017
[+] [-] TazeTSchnitzel|8 years ago|reply
[+] [-] rjeli|8 years ago|reply
[+] [-] twiss|8 years ago|reply
[+] [-] bmcooley|8 years ago|reply
[+] [-] tolgahanuzun|8 years ago|reply
[+] [-] phinnaeus|8 years ago|reply
[+] [-] pvtmert|8 years ago|reply
[+] [-] linopolus|8 years ago|reply
[+] [-] saagarjha|8 years ago|reply