top | item 16599917

Node Docker image broken

51 points| lingz | 8 years ago |github.com | reply

24 comments

order
[+] bearjaws|8 years ago|reply
Never ever use :latest unless its in your docker-compose DEV file. Try to treat docker images like you would dependencies.

We always lock down to specific versions, but we also use a self hosted docker mirror to cache everything anyway.

[+] moondev|8 years ago|reply
other labels are mutable too though. That's why this broke for other tags beside latest. Use the hash instead for a hard link, but obviously won't get any security updates.
[+] zackify|8 years ago|reply
This is one of the reasons I never use the latest version of any docker image, so I don’t repeat my constant struggles with npm packages breaking on minor version changes

Edit:

I see they were overwriting current tags.... well that’s even worse

[+] Cthulhu_|8 years ago|reply
Latest should only be used for hackery / development, but please fix it to a stable version before release.

Overwriting tags should honestly not be possible, ever. Node / NPM did that (I think) with one of their versions too. Or was it a npm package?

[+] dozzie|8 years ago|reply
Ah yes, this happens from time to time when you use somebody else's repositories with somebody else's package retention. That's why production should only use repositories that change in ways that are predictable to you (OS upstream, your own, and usually nothing else).
[+] timwis|8 years ago|reply
huh? so like, don't use open source libraries?
[+] pmarreck|8 years ago|reply
Was this untested or something?

I certainly don't see any unit tests as part of the commit that triggered this issue

(Yes, even, or perhaps especially, command line commands should be tested, somehow.)

[+] tkone|8 years ago|reply
well i mean it's broken if you use yarn. which isn't a standard part of node, so like, not really?
[+] lainga|8 years ago|reply
It's not standard, true, but it's also not an experimental feature, so one still wouldn't expect them to do wacky things like overwrite tags. I think many people expect version tagged code to not change, unless the developers specifically say they are nightly/experimental (there is a comment to that effect on the issue link).
[+] jlg23|8 years ago|reply
How comes a 7 hour old, now closed, bug report on some dead simple bridging tech that abuses tags in their SCM is news?