top | item 20524205

Ask HN: What are your coding/working ethics?

7 points| propeller_head | 6 years ago

I've always had this very strong attitude that if I am responsible for something - a task in a project management system, a service, a domain, a class, whatever - I own it and understand the problem and chase what's needed in case it needs some clarification. I'll dig the code to find what's needed to be modified/added/removed and apply the changes, usually submitting the change for review and wait for feedback.

I am not fond of the idea of another team member making changes that are related to what I'm working on - i.e. submitting code on a task that I explicitly asked for review. I don't do that and I find disrespectful.

Instead I much prefer to have the team member sit with me so we can work together and change whatever was deemed necessary or missing.

I also try to be as approachable and open as possible towards other team members but never offering advice where not required and also don't really like eavesdropping - I think it's disrespectful but, at times, it can be useful.

Totally understand and agree that code bases have a shared responsibility but keen to hear what other people are doing and how you work with other team members.

edit: title

4 comments

order

kleer001|6 years ago

Is this a humble brag? What kind of answers are you expecting? What problem are you trying to solve?

propeller_head|6 years ago

Fair question. Not a humble brag, no.

I guess I'm trying to understand what the modern IT office looks like. I have close to 20 years of experience and used to do things a certain way and accountability - of my own tasks and keeping my boss accountable as well - is high on my list of values.

When I changed jobs I'm now confronted with a new environment where people do things differently, which is totally fair.

But I don't believe working on top of other people's tasks without talking to them first is a good practice. To be honest I think it's quite rude.

That's what prompted me to ask this question. What are people doing? Do you use PR's? Do you commit on other peoples PR's? Do you talk to people? Is everything nowadays that Slack is the norm and talking is overrated?