top | item 21386288

(no title)

elweston2 | 6 years ago

Another is eat your own dogfood. If you enforce rules on others, enforce them on yourself. One project I keep an eye on and gave up trying to contribute to has users who berate others for something then turn around and do the same thing. If you make everyone else do code reviews. You do them too. If you want some sort of special spacing. Make the tools do it. Do not enforce them in code reviews. Teach the users how to setup the tools. Make a FAQ that shows how. Point people at it. You know where everything is, they dont.

Another pitfall I see is what I call 'claiming with neglect' where a user will claim something then let no one else touch it, usually in a pull request that someone put a bunch of time into. But then not do what they said they were going to do. Two years later the pull request dies on the vine and nothing changes. The person who made the request usually just wanders off due to lack of feedback.

Another is letting pull requests sit for years. Just set a max timeframe. If it does not go in that time close it. Do leave the person hanging. I get that happens on a dead project. But on a project that is obviously active? Give that pull request some love. Close it, tweak it, or merge it (something!).

discuss

order

No comments yet.