top | item 21814487

(no title)

swish_bob | 6 years ago

I'm stunned by the number of people who think that reviewing a PR is just a matter of checking the code works and looks clean.

Does nobody ask what the code is for and why you're doing it? I mean, I don't expect people to require detailed specs before approving, but a quick "what's this code for, and why are you doing it?" before addressing the details.

Surely that's the bare minimum, isn't it?

discuss

order

nahtnam|6 years ago

Even if they asked those questions, the PR would've looked pretty legit. No one directly asks "did your manager approve this?", that would be silly. When a PR is made and you're asked to review, you assume that the person went through the proper steps to get approval in the first place. In this case those other employees would've seen just another notice being added to an employee page