top | item 23126906

(no title)

tolqen | 5 years ago

it seems to compile/run fine for me on catalina but everything is absolutely huge (hidpi compatibility issues?)

discuss

order

mmm_grayons|5 years ago

Same here; font is huge on catalina. It seems like this is the culprit:

  static double get_scale(void) {
          float dpi;
        SDL_GetDisplayDPI(0, NULL, &dpi, NULL);
  #if _WIN32
          return dpi / 96.0;
  #elif __APPLE__
          return dpi / 72.0;
  #else
          return 1.0;
  #endif
  }
I found changing it to dpi / 192.0 to be fairly comfortable. It wouldn't be too hard to add a scale option and change to `return (dpi * scale) / 192.0`. The "right way" is probably to do that but also get scale by checking the screen resolution; I'd go by height due to the increasing adoption of ultra-wide monitors:

  static double get_scale(void) {
          SDL_DisplayMode dm;
          SDL_GetDesktopDisplayMode(0, &dm);
          return dm.h * scale / 786.0;
  }
Edit: works on my win10 and arch boxes.

haddr|5 years ago

still, after changing the get_scale, fonts doesn't look like they are rendered in higher resolution.

There should be a separate feature to handle higher-resolution screens.

Anyway, it feels really easy to change anything in this editor.