[jamesdsadler]

Both of these implementations seem to be missing a call to `free`, or is that something that the caller should be taking care of?

[arka2147483647]

The caller could want to move the element from one list to another, in which case the optimum impl would not free or copy the element.

[Arnavion]

It's pseudocode. The code as-is is not valid C anyway.

[rightbyte]

Now you are assuming "remove_list_entry" is not a macro!

[eperdew]

As others have said, often you don't want to free the node, you want to do something else with it. E.g., put it in a free list. However, usually if you're not freeing it, you'd null out the next field so that you don't accidentally access it when it's not part of the list (at least I would).

[jagged-chisel]

Depends on whether the list owns the nodes. I tend to write mine such that it does. Perhaps this code is demonstrative rather than complete.

[scoutt]

Why do you think the values were allocated in the heap?