top | item 26035946

(no title)

edudobay | 5 years ago

Code review is not about perfection – it is about peer review, much like in science, recognizing that a single person might have overlooked a lot of important stuff, and recognizing that collaboration usually leads to higher quality work.

Of course the desired level of quality will be different at each company/team, and each team should adjust for its own reality.

In the same team there can be times for throwaway code with low standards, and times for high quality code with strict standards. It is part of the developers' responsibility to tell them apart and make contextualised choices.

discuss

order

Person5478|5 years ago

In practice code review allows 1 or 2 people on the team to insist on their preferences throughout the project.

I once saw a 3-4 line fix turn into a rewrite of an entire page that took several full-time days to finish because the developer didn't like the original fix. I've seen a former DBA turned software dev insist on using nulls throughout the codebase rather than empty strings and ignore the argument that's not considered good practice as a software developer because they themselves are "now software developers".

And the rebuttal is always the same, "well you're just doing it wrong". Maybe, but it gets done wrong more often than right.

I'm not against code review per se, but the number of times I've seen silly and arbitrary changes because of one developer's sensibilities is way too high.

bluGill|5 years ago

If you don't care about people overlooking things and otherwise turning in low quality work, then don't do code reviews.

In short your very words prove that you are wrong and code review is about getting to perfection. (along with types, formal proofs, tests, static analysis, and a few dozen other tools that are often used).