top | item 28554036

Palantir Code Review Best Practices

3 points| aracena | 4 years ago |blog.palantir.com

1 comment

order

rgharris|4 years ago

If you aim for this point alone you're headed in the right direction:

Think like an adversary, but be nice about it. Try to “catch” authors taking shortcuts or missing cases by coming up with problematic configurations/input data that breaks their code.

The article is a great overview and goes into just enough detail - here are a couple more good points:

- Comments: concise, friendly, actionable

- Think about how you would have solved the problem. If it’s different, why is that? Does your code handle more (edge) cases? Is it shorter/easier/cleaner/faster/safer yet functionally equivalent? Is there some underlying pattern you spotted that isn’t captured by the current code?