(no title)
wayneftw | 4 years ago
Did you not realize that the repo contains a copy of every third party lib they use? It didn't go from 5 to 35 LoC in 5 years buddy xD.
Imagine also thinking that Brave will go through the trouble of leaving the webRequest API in place and then sit on their hands and not finish the other side of that equation. Too funny, sonny!
vord1080|4 years ago
Except it doesn't. And even if it did, my point is valid. Those libraries are being used in Chromium, and thus need to be maintained for use in Chromium. You can't just let your dependencies rot :)
> It didn't go from 5 to 35 LoC in 5 years buddy
It...did? Do me a favor, write a JavaScript engine, layout engine, crossplatform audio library, crossplatform gfx stack, webgl implementation, webgpu implementation, and about 9000 other things and keep it under 5 million lines. You can't. The web has legitimately expanded in scope to the point where we're pushing double digits on total lines of code.
> Imagine also thinking that Brave will go through the trouble of leaving the webRequest API in place and then sit on their hands and not finish the other side of that equation.
Now we're speculating about something that hasn't actually happened yet. Where is Brave's equivalent to addons.mozilla.org? Am I supposed to hope they have a perfect plan to deal with the limitations of Manifest v3 and just haven't announced it yet? I'll believe it when I see it.
wayneftw|4 years ago
Ummm, yes it does.
> Those libraries are being used in Chromium, and thus need to be maintained for use in Chromium.
And they certainly are... by the originators. The Chromium team maintains a few patches here and there, which is why they're in the repo to begin with friend.
> It...did?
No, I said it didn't. All of the things you listed are not originated by the Chromium team. Also, Google can't just take them away so anyone who wants to use them can. Nobody has to re-invent the entire wheel here.
> Now we're speculating.
We're using logic. Did you see the new Brave search engine? You think they can't build a store to host extensions? That's rich.