top | item 31205971

(no title)

depaya | 3 years ago

Yeah I don't agree either.

If I'm getting some feedback from a peer and they tell me "Usually your code is extremely well documented and ready to go as is, but your most recent PR doesn't cut it because xyz" I am glad they have included the "but" in the sentence so I have more context for their comment. It accomplishes two things: It lets me know they are providing this feedback from a place where they are familiar with my work (context for the feedback), and it is a complement (which is always nice to receive).

True, the actual message is what comes after the "but," but(!) that doesn't make the first half of the sentence unimportant.

discuss

order

daenz|3 years ago

Here's how I would rephrase that with "and":

"Usually your code is extremely well documented and ready to go as is and I think your most recent PR could be improved in this area." It softens the blow while still retaining the relevant context.

Dylan16807|3 years ago

So you would agree it's not meaningless?