top | item 32709424

(no title)

ceeplusplus | 3 years ago

Unfortunately the author of this PR decided to include garbage like this [1] in it, so this PR is pretty useless.

[1] https://github.com/basujindal/stable-diffusion/pull/103/file...

discuss

order

Matheus28|3 years ago

Seems like author did his work on a different fork and pushed to this one, which included all changes from the other fork...

cercatrova|3 years ago

How is that garbage? That license is part of the original SD repository, the creator Emad even talks about it in his initial post, about the OpenRAIL M License [0]:

> i) The model is being released under a Creative ML OpenRAIL-M license [https://huggingface.co/spaces/CompVis/stable-diffusion-licen...]. This is a permissive license that allows for commercial and non-commercial usage. This license is focused on ethical and legal use of the model as your responsibility and must accompany any distribution of the model. It must also be made available to end users of the model in any service on it.

[0] https://stability.ai/blog/stable-diffusion-public-release

zarzavat|3 years ago

It’s worth to point out that there’s no consensus yet on whether ML models (as in the weights) are actually copyrightable. If you’re using them, you should probably assume that they are. If you’re distributing them, you should probably assume that they aren’t.

whywhywhywhy|3 years ago

they mean the entire thing has been run through some sort of "beautifier" so there are thousands of irrelevant whitespace changes across things unrelated to the commit, which itself is around 6 lines.

kevingadd|3 years ago

You're still able to run it locally even if the license change prevents it from being merged, and it seems to be a proof of concept that may inspire other people to optimize it in different ways

sercand|3 years ago

This is the worst type of PR. Just submit a different PR for the code format changes.