(no title)
avl999 | 3 years ago
> End result: no way will I accept this kind of completely arbitrary and frankly not very intelligent patch.
> If people want to disable console printing, that's THEIR CHOICE. It could be a new config variable where you ASK people about what they want. Not this kind of idiotic tying together of things.
I thought Linus had committed to changing how he behaves in public forums? Even if he didn't like the patch, calling it "unintelligent" and "idiotic" doesn't accomplish anything. He could have just left the rest of the comments in there without using inflammatory language and it would have the same affect.
elcritch|3 years ago
Reading through the whole PR comment, you see that this is a repeating pattern in the printk system:
> And guys, I want to make it really clear how disappointed I am with > the printk tree lately. There seems to be some kind of hardline > religious fervor having taken over to make these kinds of "this is how > it has to be done, screw any sanity or common sense".
As an end user who recently used printk with PREEMPT_RT to debug a driver, I appreciate Torvald's insistence here.
> Even if he didn't like the patch, calling it "unintelligent" and "idiotic" doesn't accomplish anything.
Perhaps not, or perhaps it's an effective way to snap people out of a "religious fervor". As a developer I'd be upset at having my code called "idiotic", but would generally prefer it over someone thinking the code is idiotic but not saying it and getting stonewalled or hiding behind corporate doublespeak.
lmb|3 years ago
stjohnswarts|3 years ago
bhaak|3 years ago
petee|3 years ago
It might be better than previous language, but it's still crass and abusive on some level.
dataflow|3 years ago
Vecr|3 years ago
[0]: For all we know, there may be random users who are playing around with PREEMPT_RT. They don't have to, but they want to.
Just saying "you get no console because you wanted to try it out" is simply not acceptable.
avl999|3 years ago
dzaima|3 years ago
(an alternative would be scaling back the severity of all negative speech, but then you'd drastically reduce the range of dislike showable for the much more frequent less severe cases; I do think Linus here might have gone too hard here, but don't think it's too far off what could be considered appropriate)
avl999|3 years ago
I am calling this out because Linus specifically said that he wants to handle himself better in public, he is aware of how he comes across and wants to change, it is not an RMS type situation where the guy has no self-awareness. Reading the rest of the thread I bet he regretted his response esp considering the response of the branch maintainer.
bombcar|3 years ago
stjohnswarts|3 years ago
raverbashing|3 years ago
And yes, "not very intelligent" is a good description
pfortuny|3 years ago
“This is not the way I intend the kernel to take.”