top | item 33613849

(no title)

feep | 3 years ago

I felt the same joy on reading the overview. Cleans up the git workflow so nicely.

...until I got to pull requests (Granted, that is github, not git). But it looks like you cannot generate a standard pull request with it.

https://sapling-scm.com/docs/git/intro#pull-requests

Haven’t tried it yet, looking forward to it.

discuss

order

Shish2k|3 years ago

I actually just created my first PR from a sapling repo now - not sure why it’s not documented, but you can push your local development branch to a remote server, and in the case of github, you even get the “it looks like you’ve just pushed a local branch, would you like to turn this branch into a PR?” prompt, and it appears indistinguishable from a branch created with the Git CLI.

aseipp|3 years ago

The message generated with the hyperlink for creating a PR is actually done server-side, you can customize any git server to do this, more or less. So yes, it should behave approximately the same assuming you can just do the basic push interactions.

jcranmer|3 years ago

Reading the documentation quickly, it looks like you can generate a standard pull request, it's just that the PR may not conform to expectations if there are multiple commits.

Of course, when it comes to github PRs, there are so many different "styles" of pull request, I'm not even sure which one should be considered "standard".