top | item 36501510

(no title)

knocte | 2 years ago

You say "known issue", and add a link to it, but that's not a link to a bug, it's a bug to a comment from someone that has implemented a workaround to some sort of problem. Then it's not clear if it's really a TypeORM bug or not (if it was, there would be clear aim from the maintainers to fix it).

discuss

order

ElFitz|2 years ago

It is a link to a specific comment on a GitHub issue [0] titled "Excessive memory usage when loading models with relations" where multiple users chime in and report facing the same issue.

Someone honestly trying to refute my comment in good faith could have looked around and easily understood this.

They would then have found another comment [1], mentioning a pull request [2] supposedly fixing this exact issue, with the explicit aim to fix "performance issues".

If that was not a bug, then I don’t know what is.

But then, I understand that this can be a lot to ask.

Personally, I believe the only valid criticism that could stand here would be that, not having bothered to check if it still was an issue, I perhaps should have instead used the past tense, out of precaution, instead of assuming the bug had been fixed two to three years after being initially reported. And I shall try to remember that.

So thank you, I guess.

[0]: https://github.com/typeorm/typeorm/issues/4499

[1]: https://github.com/typeorm/typeorm/issues/4499#issuecomment-...

[2]: https://github.com/typeorm/typeorm/pull/8169