top | item 36607722

(no title)

TheBrokenRail | 2 years ago

I've never contributed to Go before, but from reading this, I have to wonder who thought this system was a good idea.

From the sounds of it, the only situation where this PR-mirroring works properly, is PRs without any comments, which I imagine are quite rare. But if your PR does have comments, then you not only have to sign up for Gerrit anyways, but you're also responsible for keeping the GitHub PR and Gerrit PR in sync. That sounds horrible.

discuss

order

reichstein|2 years ago

There are tools to automatically update the Gerrit change when the GitHub PR is updated. If you keep the comments on GitHub, eventually you may end up with an acceptable PR, which you have continuously tested in Gerrit too. Then you just land that.

If you want to do the reviews in Gerrit, then that's more annoying, but the changes can still be made on GitHub.