[richeyryan]

In my experience, the quality and depth of my code reviews were a main contributing element in my last promotion conversation for a senior+ role. It wasn't even a metric I had to scrounge up but something my manager proactively raised to justify approving the promotion along with other criteria. Other team members reported to him that my feedback helped their growth.

However, there is an aspect of being in the right team and company at the right time. If I worked in a team as experienced and knowledgeable as me, my feedback would have less value. I could also easily imagine some managers making the number of reviews an empty metric that had to be tediously gamed, much like green squares on GitHub.

Is it more common than not that senior engineers aren't appropriately rewarded for investing time in code review? Probably, most companies are imperfect in one way or another.