top | item 39880117

(no title)

raimue | 1 year ago

Read the code of the check again. It mostly checks that the required SYS_* constants are defined to be able to use the syscalls. You can compile this on a system that does not have landlock enabled in the running kernel, but the libc (which imports the kernel system call interface) has to provide the syscall numbers.

discuss

order

viraptor|1 year ago

You're right. I didn't see SYS... symbols being actually used, but they are: https://git.tukaani.org/?p=xz.git;a=blob;f=src/xz/sandbox.c;...

This doesn't change my opinion in general - that version should be exposed through a library call and knowing about the specific syscalls shouldn't be needed in xv.

Denvercoder9|1 year ago

I see your point, but suggesting adding an additional library dependency while we're discussing a supply chain attack is quite ironic.