(no title)
blowski | 1 year ago
For example "Goto considered harmful". I remember working with a very good programmer who'd used a "goto", and a much less senior one[1] rejected their PR by linking to the article.
[1] I'm ashamed to say it was me, a long time ago.
ffsm8|1 year ago
It gives the person making the change the opportunity to give context for their decision - and either change or spell out their reasoning for it, potentially giving me an opportunity to learn from them.
Another good benefit is that it doesn't "attack" the PR author in the "non-violent communication" way
blowski|1 year ago