[_gabe_]

I saw another commenter explain that it’s passed by reference, but I agree with you. The C++ Core Guidelines even mention that it’s better to use raw pointers (or pass by value and return a value) in cases like this to make the intent clear.

https://isocpp.org/wiki/faq/references#call-by-reference

[nmeofthestate]

A pointer parameter can be null and it doesn't make sense for this parameter to be null, so IMO a reference is the better choice here.

A non-const reference is just as clear a signal that the parameter may be modified as a non-const pointer. If there's no modification const ref should be used.

[jdashg]

It's about clarity of intent at the call site. Passing by mutable ref looks like `foo`, same as passing by value, but passing mutability of a value by pointer is textually readably different: `&foo`. That's the purpose of the pass by pointer style.

You could choose to textually "tag" passing by mutable ref by passing `&foo` but this can rub people the wrong way, just like chaining pointer outvars with `&out_foo`.

[gpderetta]

In theory a from_char with an optional output parameter could be useful to validate that the next field is a number and/or discard it without needing to parse it; it might even be worth optimizing for that case.

[cornstalks]

nit: I don't think the Core Guidelines actually suggests it's better. It's just "one style." There are pros and cons to both styles.