top | item 42275433

(no title)

zie1ony | 1 year ago

Recently I allowed everyone in my team to push to develop without PRs and even without doing feature branches. We review the code all together (max 2 ppl) just before the release and that's it. But great CI pipeline is must for this. It will get even better soon when AI will be able to slightly refactor the code.

discuss

order

lapcat|1 year ago

> We review the code all together (max 2 ppl) just before the release and that's it.

Is there a reason why you don't review the code immediately? You could also do that without PRs.

pavel_lishin|1 year ago

Yeah, I've heard arguments for this, and it always feels weird to me. Why go so long without review? That's just giving developers - junior and senior - opportunity to dig themselves into a hole that they don't notice until someone points out, "hey, your last five commits are buggy, but that matters less than the fact that they're implementing the wrong thing."