[oriel]

Hey this is a really cool idea.

I'm curious, for such a straight-forwarded added functionality, why you would:

1. add a very heavy editor framework (monaco) for a configuration page?

2. use actual javascript to check partial urls one at a time?

For 2. this would be better handled by a json or similar that just maps Firefox's approved url match patterns[1]? Using javascript adds potential execution vulnerabilities and possibly parsing complexity that isnt needed.

Also a word on partial urls. Given that many sites will use subdomains and redirects as a norm, expecting a site to be like "www.amazon.com" seems like it would generate a lot of excess code in order to maintain url targeting. This comes from working on a macOS plugin that did similar javascript injection based on url targeting (BeardedSpice[2]) and would have regular targeting errors, especially with more complex SPAs.

Either way, keep up the good work! Love to see projects like this attempt to improve the QoL around the browsing experience.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/Web...

[2] https://github.com/beardedspice/beardedspice

[0x696C6961]

> 1. add a very heavy editor framework (monaco) for a configuration page?

It's a configuration page which requires editing code, so I added a code editor.

> 2. use actual javascript to check partial urls one at a time?

> For 2. this would be better handled by a json or similar that just maps Firefox's approved url match patterns[1]? Using javascript adds potential execution vulnerabilities and possibly parsing complexity that isnt needed.

There are other addons which work like that:

* https://addons.mozilla.org/en-CA/firefox/addon/containerise/ * https://addons.mozilla.org/en-CA/firefox/addon/multi-account...

This addon is for more complex use-cases. For example:

    return url.searchParams.get("x-SessionName");