top | item 43448235

(no title)

daavoo | 11 months ago

> straight or rectangular objects as wobbly, as shown in the second-to-last screenshot.

This is a because the polygon is drawn as a mask in order to overlay it on the image. The actual polygon being uploaded doesn't have the wobbly features.

It is True there are cases were the predicted polygon is wobbly and I encourage people to discard them. However I didn't publish this demo until I got a first version of the model that reached some minimum quality.

There is logic in the code to simplify the shape of the predicted polygon in order to avoid having too many nodes.

discuss

order

stereo|11 months ago

Hi! The Data Working Group had a look at the data, and decided to revert the two pool changesets. The polygons the algorithm had drawn were consistently of poor quality with stray nodes and nodes far outside the pool boundaries, and the imports hadn't been discussed with local communities.

daavoo|11 months ago

Hi, thanks for the feedback.

I have disabled the hosted demo for now, and will remove the uploading part from the code in favor of showing an URL that will open the editor at the location.

If its of any help, you can find any contributed polygon with the tag `created_by=https://github.com/mozilla-ai/osm-ai-helper`. Feel free to remove all of them (or I can do it myself once I access a PC).

I will be happy to continue the discussion on what is a good prediction or not. I have mapped a lot of swimming pools myself and edited and removed a lot of (presumably) human contributed polygons that looked worse (too my eyes) than the predictions I approved to be uploaded.

boredpudding|11 months ago

Can you link the (now reverted) changesets? I can't seem to find them.

Aachen|11 months ago

I tried this out like a week ago and I was wondering the same so I tried to upload and... it's definitely uploading crap. I don't know what to tell you but all the clearly square ones I saw have bends on the straight lines

It's useful for finding ones that haven't been mapped but not for drawing them. It can get the 4 corners pretty accurate for pools that are square, many are half round at the ends though

daavoo|11 months ago

Hi, sorry if the project or narrative gave the wrong impression but my idea was to show the potential, not providing a polished solution.

As disclaimed in the demo and code, the example model was trained only with data from Galicia on a Google Colab. A robust enough models would require more data and compute.

> it's definitely uploading crap.

What was uploaded was what a human approved.

> It's useful for finding ones that haven't been mapped but not for drawing them. It can get the 4 corners pretty accurate for pools that are square, many are half round at the ends though

I couldn't dedicate enough time on the best way to refine the predictions, but happy to hear and discuss any ideas.

Ideas I have are:

- Try an oriented bounding box model instead of detection + segmentation. It will not be useful for not square shapes but will definitely generate more accurate predictions. - Build some sort of https://es.wikipedia.org/wiki/RANSAC that tries to fits rectangles and/or other shapes as an step to postprocess the predicted mask.