[maxvisser]

Some Amazon programmer tomorrow

priceIncrease := (newPrice - oldPrice) / oldPrice var trump_tariff bool

if priceIncrease > 1.0 { trump_tariff = true }

[unwind]

Please don't use if:s to assign boolean literals, just do it:

    const trump_tariff = priceIncrease > 1.0

also saves you from not initializing the variable in the default/other case. :)

[Upvoter33]

This was just someone showing you what the "Amazon programmer" was doing, and hence a deep cut reference to the likelihood of it being poor quality code :)

[throwaway519]

    const

I feel you may underestimate how often they change.

[grokkedit]

not to mention the mix of snake_case & camelCase

[Someone]

In the original code, trump_tariff is a sticky value. If that’s intended/not intended, the above introduces/fixes a bug.

[ImHereToVote]

If statements are great because they are highly readable.