top | item 43917942

(no title)

DGCA | 10 months ago

Joined a team that maintains a pretty popular TS library recently. The repo was using Biome. It was unanimously disliked by the team. Linting was broken for most people and in CI. I replaced it with Prettier + ESLint, everyone was into it, and we realized we had a bunch of issues that weren't getting reported due to it not working in CI.

discuss

order

sureIy|10 months ago

What do you mean by "linting was broken"? I seriously doubt this statement without context.

DGCA|9 months ago

I didn't set up Biome and can't tell you why it wasn't working, but people on the team couldn't get the VSCode extension to show lint errors in their editor (Cursor, primarily). I misspoke about there being a CI issue. It was more like disagreeing with their defaults, e.g. `useHookAtTopLevel` and `noUnusedVars` are off by default.

`useHookAtTopLevel` is especially confusing since other React hook rules are on, and `eslint-plugin-react-hooks` defaults its analogue to "error".

But yeah, no linting in the editor was kinda bonkers.