top | item 44398903

(no title)

BrentOzar | 8 months ago

I have a hard time getting excited about this when they have such an atrocious record of handling pull requests in VS Code already: https://github.com/microsoft/vscode/pulls

discuss

msgodel|8 months ago

It looks to me like they close nearly 30 PRs every day. That's kind of amazing.

I'm no fan of Microsoft but that's a massive maintenance burden. They must have multiple people working on this full time.

Alupis|8 months ago

If you examine the merged PR's - the overwhelming majority are from Microsoft employees. Meanwhile, community contributions sit and rot.

DidYaWipe|8 months ago

Yet the Settings UI is still a nonsensical mess.

Alupis|8 months ago

That's because it's Microsoft's Trademarked version of Open Source.

All the good FOSS vibes, without any of the hard FOSS work...

bmitc|8 months ago

Out of Apple, Google, and Microsoft, Microsoft is _by far_ the most active and open to open source and contributions.

NewsaHackO|8 months ago

I hate this analogy. Just because something is open source, doesn’t mean it is forced to commit or comment on every pull request which takes development time. If that notion really bothers you, you are free to fork VSCode and close all 600 pull requests on your fork.

tomnipotent|8 months ago

I'm not sure I see the problem. The number of merged PR's looks on the high side for a FOSS project.

https://github.com/microsoft/vscode/pulls?q=is%3Apr+is%3Aclo...

lozenge|8 months ago

I've had a lot of PRs merged. If you don't create an issue or the issue already says it doesn't suit their vision then it won't get merged. It also helps to update the PR in November/December, even if there are no merge conflicts, as that's when they "clean up" and try to close as many as possible.