top | item 44623282

(no title)

id00 | 7 months ago

Don't want to be too judgemental but does "Self Serve invite link" feature really needs 50 commits, an army of bots, countless nitpicking and 140+ messages? We are not launching Apollo to the Moon here.

I don't know this particular project but seeing threads like this kill any motivation to contribute.

discuss

order

csmantle|7 months ago

Apollo won't ever make it to the Moon if the engineers were flooded with these bot replies XD

Hilift|7 months ago

These resume's aren't going to write themselves.

repeekad|7 months ago

Haha, wait until you hear how long and how many people it takes to change the text for a single button at a company like Google

saidinesh5|7 months ago

Ngl .. the spectrum is really as wide as:

"We are a fast moving start up (even at 3-4 years old), we believe in moving fast and breaking things ... That's why we don't do code reviews or unit tests.. we just edit live running code and restart the server"

Vs

"This one line change needs 4 -5 commits to add feature flags,unit tests, integration tests - all to be reviewed by different teams and wait 1-2 months to be deployed properly to production"

mgraczyk|7 months ago

Probably one person one minute, unless it needs translation in which case potentially unbounded time

id00|7 months ago

I worked for a big tech and may be I was lucky but code wise it was much more tame. You may need to get an army of people to sign off the feature but nobody was scrutinizing my code like that

motorest|7 months ago

> Haha, wait until you hear how long and how many people it takes to change the text for a single button at a company like Google

I feel this is a needlessly obtuse statement. I'll explain you why, as I've worked professionally with frontend development. From your comment it seems you don't have that type of context.

The text that is expected to feature in a UI element is a critical factor in cross cutting concerns such as product management and UX design, and it involves things like internationalization and accessibility support. This means that if you change a line of text, it needs to be translated to all supported languages, and the translation needs to meet usability and GUI requirements. This check needs to be done in each and every single locale supported.

I can give you a very concrete example. Once I was tasked with changing a single line of text in a button featured in a dialog. It turns out the french translation ended up being too long that forced line breaks. The UI framework didn't handled those line breaks well and reflowed the whole UI, causing a huge mess. This required new translation requests, but it turned out that the new translations were too vague and ambiguous. Product Managers got involved because the french translation resulted in poor user experience. Ultimately the whole dialog was redesigned.

But to you it's just a text on a single button, isn't it?