I often find myself leaving review comments on pull requests where I was surprised. I'll state as much: This surprised me - I was expecting XYZ at this point. Or I wasn't expecting X to be in charge of Y.
I like to say that the reviewer is always right in that sense, if something is surprising, confusing, unexpected. Since I've been looking at the code for hours, I don't have a valid perspective anymore.
_kb|7 months ago
https://blog.codinghorror.com/whos-your-coding-buddy/
federiconafria|7 months ago
unknown|7 months ago
[deleted]