top | item 45371809

(no title)

2sk21 | 5 months ago

Reviewing someone else's large pull request is like having a second task in parallel with what you are working on yourself!

discuss

order

eterm|5 months ago

So don't do it in parallel.

Completely park other tasks, spend time on the review and record that time appropriately.

There's nothing wrong with saying you spent the previous day doing a large review. It's a part of the job, it is "what you're working on".

sexyman48|5 months ago

You might as well go into HR. Everyone knows reviewing other people's PRs is like nurturing their kids at the expense of your own.

chrisweekly|5 months ago

It's not "like" another task, it IS another task!

osigurdson|5 months ago

Yeah but it is just a quick look, "yep", "yep", "oh what about this"?, "wow we dodged a bullet there". Its like self managed error correction that the collective does on its own. Fast, simple and produces good results. The less software you write the more this resonates.