top | item 45424618

(no title)

no_circuit | 5 months ago

Right, for example, there are no comments on why something there is something called a PromiseIdAllocator that starts with the magic number "1":

Yet there is a public interface that allows for initialization with "0":

It's like the LLM was able to predict that 1 is needed in the protocol, but wasn't relevant to check in the boilerplate.

I don't have a problem with newtype-all-the-things to ensure correctness in some areas, but no comments/constants does not lead to confidence.

discuss

No comments yet.