top | item 46152964

(no title)

chowells | 2 months ago

Handling negative feedback on a PR is a necessary skill for a developer. A manager should only get involved if it becomes hostile. Negative is very far from hostile.

discuss

order

jjk166|2 months ago

Handling negative feedback doesn't involve going to anybody - neither the manager, nor the person who gave the PR. Someone giving negative feedback is not supposed to be a conflict in need of resolution. We are talking about a situation where there is a conflict that needs to be resolved, ie that it has already become hostile.

If they are going to their manager, and then the manager, rather than convincing them that they are over-reacting, is instead going to you and telling you that there's something wrong with the feedback you gave, you should handle that negative feedback.

cj|2 months ago

> We are talking about a situation where there is a conflict that needs to be resolved

You’re overlooking the fact that your threshold for what a “conflict” is might be different from the next person’s.

There’s no universally “correct” way to label whether something is a conflict or not. People have varying perceptions.