top | item 46299676

(no title)

madog | 2 months ago

Something like Gerrit. Instead of carefully crafting a logical series of patches that are all well documented with commit messages, PRs are just garbage filled diff soup of "fix typo" commits. I hate it. It's hard to review and seems to be based on putting the least amount of effort into proposing changes to the code. See https://gist.github.com/thoughtpolice/9c45287550a56b2047c631...

discuss

order

Cthulhu_|2 months ago

That's down to culture and (self) discipline, not tools.

madog|2 months ago

It's not entirely, because Github simply does not support inter-version diffs when you have multiple commits. If you force push onto multiple commits there is no way to show a diff between version 2 and version 3 of those commits. How Github lacks such basic (and imo necessary) functionality in 2025 is amazing to me.

Something like linked and dependent PRs in a chain would go someway to replicating Gerrit but again this basic functionality is not available out of the box for whatever reason.

sublimefire|2 months ago

Well but this is controllable, i.e. it is people who choose to do this not the platform. Very much an internal design choice.