(no title)
adeebshihadeh | 21 days ago
Not sure about the trust part. Ideally, you can evaluate the change on its own.
In my experience, I immediately know whether I want to close or merge a PR within a few seconds, and the hard part is writing the response to close it such that they don't come back again with the same stuff.
(I review a lot of PRs for openpilot - https://github.com/commaai/openpilot)
jgauth|21 days ago
ngcazz|21 days ago
999900000999|21 days ago
Even if I trust you, I still need to review your work before merging it.
Good people still make mistakes.
adeebshihadeh|21 days ago
rafram|21 days ago
BowBun|21 days ago
latency-guy2|21 days ago