top | item 47043445

(no title)

throwaway150 | 14 days ago

> Every PR needs to be reviewed.

Why would you review a PR that you are never going to merge?

discuss

allthetime|14 days ago

You have to first determine whether or not you might want to merge it...

protocolture|14 days ago

Having not reviewed it, how do you know you are never going to merge?

throwaway150|14 days ago

If a PR claims to solve a problem that I don't need, then I can skip its review because I'll never merge it.

I don't think every PR needs reviewing. Some PRs we can ignore just by taking a quick look at what the PR claims to do. This only requires a quick glance, not a PR review.