(no title)
The_SamminAter | 4 days ago
1. It changes my browser theme frequently. Please do not. I've only taken a quick look at how/why, but you seem to apply the stock Firefox dark themes multiple times - in sidebar/sidebar.js, sidebar/theme-init.js, background/background.js, and possibly in sidebar/manage.js and sidebar/reader-page.js. This is just from a quick grep.
2. The authentication structure is quite easy to modify/bypass. Yes, you have server-sided authentication, but modules/auth.js does all of the work - and as such can be both taken offline and be modified to set arbutrary user information and return a valid, non-expired subscription. Though, isAuthenticated returning true is even easier.
You have made quite an interesting and useful extension, which I do plan on trialing once I fix the theme-changing issue. Authentication is hard and can never be perfect, but I do believe that it is robust enough for the vast majority of users. Thank you for sharing your work, and I await to hear how compliant/polite it is on rachelbythebay's rss reader test.
No comments yet.