[yobbo]

The code might be a little verbose which is tiresome for humans to read and follow. Structure and functions look idiomatic. It seems to be using xml parser idioms which makes it readable.

It could be doing double checks in both tokeniser and parser and things like that.

Actually looks like a good starting point and reference for someone working on xml parsers in rust.