I think this comment/discussion ends up over-emphasizing the 'strangeness' of the line-number situation with this library, the page linked ends with: 'This position is subject to discuss. Also it doesn’t stop anyone from forking the code and maintaining line-numbers implementation separately.', which seems pretty reasonable to me!
Yeah, this is pretty much the behavior that I want to see from open source maintainers: make decisions and build conventions but be open to having your mind convinced of alternatives.
I already like this one better, to be honest. It also already has Julia and Rust support. If it were to include Elixir support as well, it'd be perfect.
It does seem more appropriate to have a separate module for line numbers. I would definitely understand the separation of concerns argument, but the maintainer instead makes some sort of emotional appeal about clutter and simplicity to explain why there is no line number support.
Many popular syntax highlighting libraries do include this functionality. For example, the popular Python syntax highlighter "Pygments" supports line numbers[0].
I understand the author's point-of-view on this, but disabling line numbers sounds like something that should be user-controllable. Right now it feels like a misfeature, whereas "we don't implement line numbers by default, but if you want them, do this and that and you can have them" would feel way more like a good feature to have.
dingdingdang|11 years ago
ajsharma|11 years ago
pothibo|11 years ago
luddypants|11 years ago
thomasfoster96|11 years ago
yellowapple|11 years ago
ericHosick|11 years ago
gelatocar|11 years ago
jimmytucson|11 years ago
awhitty|11 years ago
lelandbatey|11 years ago
[0] - http://pygments.org/docs/formatters/#HtmlFormatter
Octplane|11 years ago
http://uu.zoy.fr/p/T4RwhQ#x=2zHnAK7/HQAxDmEA
yellowapple|11 years ago
cbhl|11 years ago
https://groups.google.com/d/msg/highlightjs/UVJaQcQNC1c/1C6U...
aw3c2|11 years ago