I'm not really sure what you mean. We don't know what the task was that he had to solve. I was providing an example of a situation in which 66 commits could be seen as a bad thing.
For a typical whiteboard coding problem, I also wouldn't want to see 60+ commits.
I remember when I first got started with git I committed at an absurd frequency. I don't think it's that unreasonable for someone straight out of college to be relatively new to git, and thus do the same thing.
I remember later on I wrote a script that listened to git hooks and rebuilt my project on a remote server. I was still testing manually at that time, as we all do in the beginning, which resulted in a large number of commits so that I could view the results on the server.
I think it's ok to ask "why do you have so many commits?" but not "why do you have so many commits?!?!?!". It's also not ok to ASSUME that a large number of commits is a bad thing automatically, unless you have reasons far better then any submitted in this thread.
nilkn|10 years ago
For a typical whiteboard coding problem, I also wouldn't want to see 60+ commits.
bjones22|10 years ago
I remember later on I wrote a script that listened to git hooks and rebuilt my project on a remote server. I was still testing manually at that time, as we all do in the beginning, which resulted in a large number of commits so that I could view the results on the server.
I think it's ok to ask "why do you have so many commits?" but not "why do you have so many commits?!?!?!". It's also not ok to ASSUME that a large number of commits is a bad thing automatically, unless you have reasons far better then any submitted in this thread.
monksy|10 years ago
pd1|10 years ago